[prosody-dev] Re: [Buildroot] [PATCH] prosody: bump to version 0.10.0

[Dushara Jayasinghe]

Hi Francois,

I'm listed as the maintainer for Prosody simply by virtue of the
fact that I first added the Prosody package. I'm not a Prosody
dev, so these are more questions than comments...

-- Not essential, but recommended
+ "carbons"; -- Keep multiple clients in sync
+ "pep"; -- Enables users to publish their mood, activity, playing music and more
"private"; -- Private XML storage (for room bookmarks, etc.)
+ "blocklist"; -- Allow users to block communications with other users
"vcard"; -- Allow users to set vCards

I had a brief look at the release notes, and they state that the new modules that you added
are 'native', does that mean that the required libraries are automatically included in the
install?

-- Other specific functionality
- "posix"; -- POSIX functionality, sends server to background, enables syslog, etc.

Did you mean to comment this out?

--- These are the SSL/TLS-related settings. If you don't want
--- to use SSL/TLS, you may comment or remove this
-ssl = {
- key = "certs/localhost.key";
- certificate = "certs/localhost.crt";
-}

Does Prosody start without any certificates? The config I provided was just enough to allow
Prosody to start and accessible (albeit the user needs to make adjustments to suite that site).

-authentication = "internal_plain"
+authentication = "internal_hashed"

That's a good idea.

log = {
- -- info = "prosody.log"; -- Change 'info' to 'debug' for verbose logging
- -- error = "prosody.err";
- "*syslog"; -- Logging to syslog
+ info = "prosody.log"; -- Change 'info' to 'debug' for verbose logging
+ error = "prosody.err";

Where are these files created? In root I believe. My preferance is to just use syslog. I think
the posix module needs to be enabled for syslog to work though.

-pidfile = "/var/run/prosody/prosody.pid"

Is this intentional? I used the pidfile to allow the startup script to terminate the service.
Can you still terminate the service without this?

As I said earlier, I'm not a Prosody dev, so your changes may be perfectly valid. If so,
explaining those changes in the commit message would be useful. I've CCd the dev mailing list
in case they have additional comments.

Thanks,

Dushara

[n***@gmail.com]

Link to patch <https://patchwork.ozlabs.org/patch/825826/> for reference

Post by Dushara Jayasinghe
Hi Francois,
I'm listed as the maintainer for Prosody simply by virtue of the
fact that I first added the Prosody package. I'm not a Prosody
dev, so these are more questions than comments...

-- Not essential, but recommended
+ "carbons"; -- Keep multiple clients in sync
+ "pep"; -- Enables users to publish their mood,

activity, playing music and more

"private"; -- Private XML storage (for room bookmarks,

etc.)

+ "blocklist"; -- Allow users to block communications

with other users

"vcard"; -- Allow users to set vCards

I had a brief look at the release notes, and they state that the new modules that you added
are 'native', does that mean that the required libraries are automatically included in the
install?

-- Other specific functionality
- "posix"; -- POSIX functionality, sends server to

background, enables syslog, etc.
Did you mean to comment this out?

--- These are the SSL/TLS-related settings. If you don't want
--- to use SSL/TLS, you may comment or remove this
-ssl = {
- key = "certs/localhost.key";
- certificate = "certs/localhost.crt";
-}

Does Prosody start without any certificates? The config I provided was just enough to allow
Prosody to start and accessible (albeit the user needs to make adjustments
to suite that site).

-authentication = "internal_plain"
+authentication = "internal_hashed"

That's a good idea.

log = {
- -- info = "prosody.log"; -- Change 'info' to 'debug' for

verbose logging

- -- error = "prosody.err";
- "*syslog"; -- Logging to syslog
+ info = "prosody.log"; -- Change 'info' to 'debug' for verbose

logging

+ error = "prosody.err";

Where are these files created? In root I believe. My preferance is to just
use syslog. I think
the posix module needs to be enabled for syslog to work though.

-pidfile = "/var/run/prosody/prosody.pid"

Is this intentional? I used the pidfile to allow the startup script to
terminate the service.
Can you still terminate the service without this?
As I said earlier, I'm not a Prosody dev, so your changes may be perfectly valid. If so,
explaining those changes in the commit message would be useful. I've CCd
the dev mailing list
in case they have additional comments.
Thanks,
Dushara

[Matthew Wild]

Post by Dushara Jayasinghe
Hi Francois,
I'm listed as the maintainer for Prosody simply by virtue of the
fact that I first added the Prosody package. I'm not a Prosody
dev, so these are more questions than comments...

Prosody dev here...

Post by Dushara Jayasinghe

-- Not essential, but recommended
+ "carbons"; -- Keep multiple clients in sync
+ "pep"; -- Enables users to publish their mood, activity, playing music and more
"private"; -- Private XML storage (for room bookmarks, etc.)
+ "blocklist"; -- Allow users to block communications with other users
"vcard"; -- Allow users to set vCards

I had a brief look at the release notes, and they state that the new modules that you added
are 'native', does that mean that the required libraries are automatically included in the
install?

These modules were added in 0.10. They don't require any additional
dependencies outside of Prosody.

Post by Dushara Jayasinghe

-- Other specific functionality
- "posix"; -- POSIX functionality, sends server to background, enables syslog, etc.

Did you mean to comment this out?

This module is auto-loaded in 0.10 (it automatically detects the
appropriate platform module to load). This was triggered by some users
"accidentally" removing/commenting it out and then asking why their
Prosody was broken. It can still be disabled by adding it to
modules_disabled if necessary.

Post by Dushara Jayasinghe

--- These are the SSL/TLS-related settings. If you don't want
--- to use SSL/TLS, you may comment or remove this
-ssl = {
- key = "certs/localhost.key";
- certificate = "certs/localhost.crt";
-}

Does Prosody start without any certificates? The config I provided was just enough to allow
Prosody to start and accessible (albeit the user needs to make adjustments to suite that site).

It will start without any certificates. However it doesn't need this
configuration in 0.10, we've moved to automatic certificate location,
where Prosody scans a location on the filesystem to pick up the
correct certificate/key for a domain:
https://prosody.im/doc/certificates#automatic_location

Post by Dushara Jayasinghe

log = {
- -- info = "prosody.log"; -- Change 'info' to 'debug' for verbose logging
- -- error = "prosody.err";
- "*syslog"; -- Logging to syslog
+ info = "prosody.log"; -- Change 'info' to 'debug' for verbose logging
+ error = "prosody.err";

Where are these files created? In root I believe. My preferance is to just use syslog. I think
the posix module needs to be enabled for syslog to work though.

Prosody will chdir to its data directory at startup, so they are
likely being created there. When Prosody is installed system-wide, we
recommend absolute paths here. The destination directory needs to be
writeable by Prosody (/var/log generally isn't, so packages usually
create and use /var/log/prosody).

Post by Dushara Jayasinghe

-pidfile = "/var/run/prosody/prosody.pid"

Is this intentional? I used the pidfile to allow the startup script to terminate the service.
Can you still terminate the service without this?

This is still a required option if you want to control Prosody after
it daemonizes. However some init systems don't need it.

Regards,
Matthew